Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: start the experiment with modulepreload on qwik.dev #6862

Merged
merged 1 commit into from
Sep 5, 2024
Merged

chore: start the experiment with modulepreload on qwik.dev #6862

merged 1 commit into from
Sep 5, 2024

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Sep 4, 2024 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

As discussed, modulepreload doubles the FCP/LCP on lighthouse default throttling and therefore pagespeed (which uses lighthouse default throttling). We need to gather real data for modulepreload to see how it impacts FCP/LCP on real devices/connections. Perhaps it's only on the lighthouse simulations that FCP/LCP isn't good.

P.S. I verified that everything still works.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner September 4, 2024 19:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 2aaf524

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2aaf524

gioboa
gioboa approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect to me. @maiieul 💪

@maiieul
Copy link
Contributor Author

maiieul commented Sep 5, 2024

@gioboa always so nice 😅🫶

@maiieul
Copy link
Contributor Author

maiieul commented Sep 5, 2024

We'll have to deploy the docs site after merging.

@gioboa gioboa merged commit 36eb7d0 into QwikDev:main Sep 5, 2024
13 checks passed
gioboa added a commit that referenced this pull request Sep 5, 2024
@gioboa
Revert "chore: start the experiment with modulepreload on qwik.dev (#…
5b9fbdf 
…6862)"

This reverts commit 36eb7d0.
@gioboa gioboa mentioned this pull request Sep 5, 2024
Merged
gioboa added a commit that referenced this pull request Sep 5, 2024
@gioboa
Revert "chore: start the experiment with modulepreload on qwik.dev" (#…
5889287 
…6864)

Revert "chore: start the experiment with modulepreload on qwik.dev (#6862)"

This reverts commit 36eb7d0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiieul @gioboa