Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: start modulepreload experiment #6867

Merged
merged 5 commits into from
Sep 6, 2024
Merged

chore: start modulepreload experiment #6867

merged 5 commits into from
Sep 6, 2024

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Sep 5, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner September 5, 2024 21:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b7e8a96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gioboa
gioboa approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪@maiieul

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b7e8a96

gioboa
gioboa requested changes Sep 5, 2024
View reviewed changes
packages/docs/src/root.tsx Outdated Show resolved Hide resolved
@maiieul maiieul requested a review from gioboa September 6, 2024 19:55
thejackshelton-kunaico
thejackshelton-kunaico approved these changes Sep 6, 2024 •
edited by thejackshelton
Loading
View reviewed changes
thejackshelton
thejackshelton approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gioboa
gioboa approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏@maiieul

@maiieul maiieul merged commit 74eb861 into QwikDev:main Sep 6, 2024
13 checks passed
wmertens pushed a commit that referenced this pull request Sep 24, 2024
@maiieul @wmertens
chore: start modulepreload experiment (#6867)
87d7675 
* chore: start the experiment with modulepreload on qwik.dev

* chore: add visible task to unregister service-worker.js

* chore: also unregister qwik-prefetch-service-worker.js

* chore: set unregister script as inlined script

* chore: remove visible task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejackshelton-kunaico thejackshelton-kunaico thejackshelton-kunaico approved these changes

@thejackshelton thejackshelton thejackshelton approved these changes

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maiieul @gioboa @thejackshelton @thejackshelton-kunaico