INFRA: migration from tsm to tsx #6877

JerryWu1234 · 2024-09-12T02:38:46Z

#6856

What is it?

Feature / enhancement
Bug
Docs / tests / types / typos
Infra

Description

Checklist:

My code follows the developer guidelines of this project
I have performed a self-review of my own code
I have ran pnpm change and documented my changes
I have made corresponding changes to the Qwik docs
Added new tests to cover the fix / functionality

changeset-bot · 2024-09-12T02:38:50Z

🦋 Changeset detected

Latest commit: 399c2ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
create-qwik	Patch
@builder.io/qwik	Patch
@builder.io/qwik-city	Patch
eslint-plugin-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

intellix · 2024-09-12T03:33:35Z

just out of curiosity, what's the problem with TSM? was thinking that it looked promising for some of our other projects

JerryWu1234 · 2024-09-12T03:42:28Z

just out of curiosity, what's the problem with TSM? was thinking that it looked promising for some of our other projects

”because tsm doesn't support its import map.“ this can answer your question ?

wmertens · 2024-09-12T09:44:39Z

@intellix vfile/vfile#90 (comment)

package.json

tsconfig.json

…qwik into 6856_tsm_to_ts_node

JerryWu1234 · 2024-09-19T02:17:03Z

@wmertens I tested pnpm run build.core and pnpm run build.full looks greet. and quick than ever

pkg-pr-new · 2024-09-19T02:49:03Z

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6877

npm i https://pkg.pr.new/@builder.io/qwik-city@6877

npm i https://pkg.pr.new/eslint-plugin-qwik@6877

npm i https://pkg.pr.new/create-qwik@6877

commit: 399c2ab

JerryWu1234 · 2024-09-19T02:50:33Z

@wmertens I don't how to fix it, and other it looks greet

package.json

github-actions · 2024-10-04T13:55:52Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	`399c2ab`

wmertens

I think it would be best to start from scratch with https://www.npmjs.com/package/tsimp as described in the comment. It doens't need swc added etc, and can be a drop-in replacement/speedup.

.changeset/loud-deers-run.md

package.json

starters/playwright.config.ts

package.json

JerryWu1234 · 2024-10-29T01:28:34Z

@wmertens Please help me check this PR, as it is easy to get conflicts.

.changeset/loud-deers-run.md

JerryWu1234 · 2024-10-31T01:21:17Z

@shairez done

seems like it was fixed

shairez · 2024-10-31T10:51:08Z

thanks @JerryWu1234 !
good job!

JerryWu1234 · 2024-10-31T12:22:25Z

thanks @JerryWu1234 ! good job!

thanks, I think this PR is my biggest PR currently

fea: switching tsm to ts-node in packagejson

cbc56b7

Merge branch 'main' into 6856_tsm_to_ts_node

984f804

wmertens reviewed Sep 12, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

tsconfig.json Outdated Show resolved Hide resolved

wuls added 4 commits September 19, 2024 09:28

feat: ts-node

d1e9b05

Merge branch '6856_tsm_to_ts_node' of https://github.com/JerryWu1234/…

b30303f

…qwik into 6856_tsm_to_ts_node

feat: ts-node

3175c2d

feat: ts-node

dc7f1e9

JerryWu1234 marked this pull request as ready for review September 19, 2024 02:16

JerryWu1234 requested a review from a team as a code owner September 19, 2024 02:16

wuls and others added 3 commits September 19, 2024 10:26

feat: ts-node

961773e

feat: ts-node

447894c

Update qwik-binding-map.ts

832e77b

JerryWu1234 added 3 commits September 22, 2024 22:30

Merge branch 'main' into 6856_tsm_to_ts_node

077be99

Merge branch 'main' into 6856_tsm_to_ts_node

9b4c16f

Merge branch 'main' into 6856_tsm_to_ts_node

5400426

octet-stream reviewed Oct 3, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

JerryWu1234 added 2 commits October 4, 2024 08:51

Merge branch 'main' into 6856_tsm_to_ts_node

913b1d8

fix version

4377c65

shairez assigned JerryWu1234 Oct 8, 2024

Merge branch 'main' into 6856_tsm_to_ts_node

bd33dd1

wmertens requested changes Oct 12, 2024

View reviewed changes

.changeset/loud-deers-run.md Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

JerryWu1234 changed the title ~~fea: switching tsm to ts-node in packagejson~~ feat: switching tsm to ts-node in packagejson Oct 12, 2024

test

87fc242

JerryWu1234 marked this pull request as draft October 14, 2024 06:22

JerryWu1234 and others added 4 commits October 14, 2024 14:22

Merge branch 'main' into 6856_tsm_to_ts_node

9c38fb4

test

d1ad090

test

66f5625

test

b322ebd

wmertens previously requested changes Oct 14, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

starters/playwright.config.ts Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

wuls and others added 2 commits October 15, 2024 10:52

fix test

d38a112

Merge branch 'main' into 6856_tsm_to_ts_node

c98f6eb

JerryWu1234 marked this pull request as ready for review October 15, 2024 02:53

JerryWu1234 requested a review from a team as a code owner October 15, 2024 02:53

wuls and others added 3 commits October 22, 2024 09:29

solve conflict

327b02d

solve conflict

9f4c226

Merge branch 'main' into 6856_tsm_to_ts_node

1b6d382

ianlet reviewed Oct 29, 2024

View reviewed changes

.changeset/loud-deers-run.md Outdated Show resolved Hide resolved

JerryWu1234 changed the title ~~feat: switching tsm to ts-node in packagejson~~ INFRA: migration from tsm to tsx Oct 31, 2024

wuls added 2 commits October 31, 2024 09:12

fix bug

b491a0d

fix conflict

399c2ab

shairez approved these changes Oct 31, 2024

View reviewed changes

shairez merged commit b97b6d2 into QwikDev:main Oct 31, 2024
19 checks passed

github-actions bot mentioned this pull request Oct 31, 2024

Version Packages #6940

Merged

JerryWu1234 deleted the 6856_tsm_to_ts_node branch October 31, 2024 12:21

shairez mentioned this pull request Nov 4, 2024

tsm is no longer supported #6856

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

INFRA: migration from tsm to tsx #6877

INFRA: migration from tsm to tsx #6877

JerryWu1234 commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

intellix commented Sep 12, 2024

JerryWu1234 commented Sep 12, 2024

wmertens commented Sep 12, 2024

JerryWu1234 commented Sep 19, 2024

pkg-pr-new bot commented Sep 19, 2024 •

edited

Loading

JerryWu1234 commented Sep 19, 2024

github-actions bot commented Oct 4, 2024 •

edited

Loading

wmertens left a comment

JerryWu1234 commented Oct 29, 2024

JerryWu1234 commented Oct 31, 2024

shairez commented Oct 31, 2024

JerryWu1234 commented Oct 31, 2024

INFRA: migration from tsm to tsx #6877

INFRA: migration from tsm to tsx #6877

Conversation

JerryWu1234 commented Sep 12, 2024 • edited Loading

What is it?

Description

Checklist:

changeset-bot bot commented Sep 12, 2024 • edited Loading

🦋 Changeset detected

intellix commented Sep 12, 2024

JerryWu1234 commented Sep 12, 2024

wmertens commented Sep 12, 2024

JerryWu1234 commented Sep 19, 2024

pkg-pr-new bot commented Sep 19, 2024 • edited Loading

JerryWu1234 commented Sep 19, 2024

github-actions bot commented Oct 4, 2024 • edited Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

wmertens left a comment

Choose a reason for hiding this comment

JerryWu1234 commented Oct 29, 2024

JerryWu1234 commented Oct 31, 2024

shairez commented Oct 31, 2024

JerryWu1234 commented Oct 31, 2024

JerryWu1234 commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading