feat(qwik-city): noSPA (experimental)
#6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also refactors the SPA init loading to leverage qwikloader and sync$, reducing HTML size.
by using a string enum we can refer to the items directly and they end up in the API docs. Plus the code is cleaner.
🦋 Changeset detectedLatest commit: 60df208 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
thejackshelton
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
This PR is inspired by #6933. Confirmed that this code is not present in the source when noSPA is enabled, and the SPA shim code is minified.
Tried this in a production app and didn't run into any problems. LGTM for experimental use 👍
gioboa
approved these changes
Oct 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the SPA init, slightly reducing code size and startup speed in MPA-only applications.
This is an experimental feature.