Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move internals out of JSXNode #7044

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore: move internals out of JSXNode #7044

merged 1 commit into from
Nov 14, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Nov 5, 2024

remove immutableProps and flags from the public type.

This makes it so that v1 and v2 can be type compatible.

Technically it's a breaking API change but these fields were never meant for public consumption and they're still present.

@wmertens wmertens requested review from a team as code owners November 5, 2024 01:38
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 26af133

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7044
npm i https://pkg.pr.new/@builder.io/qwik-city@7044
npm i https://pkg.pr.new/eslint-plugin-qwik@7044
npm i https://pkg.pr.new/create-qwik@7044

commit: 53e1904

Copy link
Contributor

github-actions bot commented Nov 14, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 53e1904

`immutableProps` and `flags`
Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @wmertens !

@wmertens wmertens merged commit cda8c72 into main Nov 14, 2024
16 checks passed
@wmertens wmertens deleted the fix-dev branch November 14, 2024 22:28
This was referenced Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants