Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): path handling in dev #7180

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(dev): path handling in dev #7180

wants to merge 5 commits into from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Dec 19, 2024

Fixes #7135

Before merging:

  • test on windows, I can't do it. Just running pnpm docs.dev and alt-clicking a component to open in editor should work.

@wmertens wmertens requested a review from a team as a code owner December 19, 2024 21:04
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 4bb9dbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens marked this pull request as draft December 22, 2024 10:19
- remove srcDir usage in optimizer
- remove dev_path and devPath from optimizer options
- don't change path of transformed files
- use relative paths in transform calls
- use relative path in source map
- use relative path in click-to-component
doesn't seem to have any effect
This pretends that the src/ dir is the root of the project as far as the optimizer is concerned, and makes sure the click-to-component knows about it.

This way the relative paths given to the optimizer are the same as before.
@wmertens wmertens marked this pull request as ready for review December 22, 2024 15:39
@wmertens wmertens requested review from a team as code owners December 22, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Option-click not working to open source - DX
1 participant