Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 15, 2025

Handle SetAttribute journal operation with null value for inputs correctly (removing the prop)

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2025

🦋 Changeset detected

Latest commit: dce9976

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo marked this pull request as ready for review November 15, 2025 09:22
@Varixo Varixo requested a review from a team as a code owner November 15, 2025 09:22
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Nov 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview dce9976

@Varixo Varixo force-pushed the v2-fix-input-undefined-value branch from bf14b76 to dce9976 Compare November 15, 2025 09:42
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8157
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8157
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8157
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8157

commit: dce9976

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 1ff482f into build/v2 Nov 15, 2025
20 checks passed
@wmertens wmertens deleted the v2-fix-input-undefined-value branch November 15, 2025 12:24
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[🐞] Change input value from "something" to undefined sets the value as "null"

3 participants