Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 16, 2025

Defer reading QScopedStyle until promise resolves for SSR. Without it we can read scoped id to early when it is not set yet

@Varixo Varixo self-assigned this Nov 16, 2025
@Varixo Varixo requested a review from a team as a code owner November 16, 2025 13:38
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2025

🦋 Changeset detected

Latest commit: 8af7775

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo linked an issue Nov 16, 2025 that may be closed by this pull request
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Nov 16, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8161
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8161
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8161
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8161

commit: 8af7775

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8af7775

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 2f4ab02 into build/v2 Nov 16, 2025
21 checks passed
@wmertens wmertens deleted the v2-await-jsxoutput-scoped-style branch November 16, 2025 18:46
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[🐞] scoped styles don't work on Promise throw

3 participants