Improved: changed the function name to downloadFile in DownloadLogsFi…

…lePopover and parameter type(hotwax#680)
R-Sourabh · Nov 13, 2024 · 8047986 · 8047986
1 parent 0e6ba95
commit 8047986
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/components/DownloadLogsFilePopover.vue b/src/components/DownloadLogsFilePopover.vue
@@ -2,13 +2,13 @@
   <ion-content>
     <ion-list>
       <ion-list-header>{{ dataManagerLog.logId }}</ion-list-header>
-      <ion-item button @click="downloadLogFile('logFile')">
+      <ion-item button @click="downloadFile('logFile')">
         {{ translate('Log file') }}
       </ion-item>
-      <ion-item button @click="downloadLogFile('uploadedFile')">
+      <ion-item button @click="downloadFile('uploadedFile')">
         {{ translate('Uploaded file') }}
       </ion-item>
-      <ion-item button :disabled="!dataManagerLog?.errorRecordContentId" lines="none" @click="downloadLogFile('failedRecords')">
+      <ion-item button :disabled="!dataManagerLog?.errorRecordContentId" lines="none" @click="downloadFile('failedRecords')">
         {{ translate('Failed records') }}
       </ion-item>
     </ion-list>
@@ -39,7 +39,7 @@ export default defineComponent({
   },
   props: ["dataManagerLog"],
   methods: {
-    async downloadLogFile(type: any) {
+    async downloadFile(type: string) {
       let dataResource = {} as any;
 
       if (type === 'logFile') {
@@ -53,7 +53,7 @@ export default defineComponent({
         dataResource.name = this.dataManagerLog.errorRecordContentName
       }
 
-      if (dataResource) {
+      if (dataResource.dataResourceId) {
         try {
           const response = await JobService.fetchFileData({
             dataResourceId: dataResource.dataResourceId