Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from clientvideooverrides.cpp #784

Conversation

ASpoonPlaysGames
Copy link
Contributor

Depends on #780

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that .bik files can still be loaded from mod directories (custom main menus)

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 26, 2024
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good :>

@F1F7Y F1F7Y removed the needs code review Changes from PR still need to be reviewed in code label Aug 27, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. My custom main menu video still played :D

image

@GeckoEidechse GeckoEidechse merged commit 3a930e4 into R2Northstar:main Aug 27, 2024
4 checks passed
@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Aug 27, 2024
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/clientvideooverrides.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
)

Run callbacks for nested modules, and prevent running callbacks multiple times for the same module.
Manually hook BinkOpen
Remove AUTOHOOK_INIT and AUTOHOOK_DISPATCH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants