Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of Autohook from modlocalisation.cpp #792

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Remove uses of Autohook from modlocalisation.cpp #792

merged 4 commits into from
Aug 30, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that loading localisation files from mods still works as expected.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 29, 2024
GeckoEidechse
GeckoEidechse approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing
image

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Aug 29, 2024
F1F7Y
F1F7Y approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🐈

@F1F7Y F1F7Y removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 30, 2024
@F1F7Y F1F7Y merged commit 4ff226d into R2Northstar:main Aug 30, 2024
5 checks passed
@GeckoEidechse GeckoEidechse mentioned this pull request Aug 31, 2024
Open
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/modlocalisation.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
@ASpoonPlaysGames @wolf109909
client: Remove uses of Autohook from modlocalisation.cpp (R2Northst…
aef8614 
…ar#792)

Remove use of AUTOHOOK macro from `modlocalisation.cpp`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@F1F7Y F1F7Y F1F7Y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y