Pruning #103
Merged
Pruning #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll also add you as a contributor to this repo. Feel free to self-merge once CI completes. |
This is not true. We are consistently adding trailing newlines in RAC's codebase. I'll submit a PR to address this. |
|
@ikesyo I am pretty sure I saw files without last lines. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a humble attempt to ease up @NachoSoto's self assigned task ReactiveCocoa/ReactiveCocoa#2790. Hopefully this will help speeding up the process. 🎉🎉🎉
What's in this PR?
These changes were based on what I see in the ReactiveCocoa repo, except the last one, where I went with simplicity.
SignalProducersSignals andPropertyTypes.import Foundationwas used, in others it wasn't. I removed it, to make the header simpler.