Implement rex_animating for UIActivityIndicatorView #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// Setting the value of this property to `true` starts animation of the progress indicator, | ||
| /// and setting it to `false` stops animation. | ||
| public var animating: Bool { |
There was a problem hiding this comment.
Sorry for the late, but this seems confusing to me. I think the logic should be implemented in rex_animating directly.
There was a problem hiding this comment.
Thanks for feedback. I just prefer having both bindable and normal properties, but was not sure if Rex needs normal one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bindable property
rex_animatingto UIActivityIndicatorView. It uses helper propertyanimating.