Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for UIPageControl #148

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

added support for UIPageControl #148

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f286189
added support for UIPageControl
tcurdt Jul 24, 2016
da9a071
fixed copy&paste error in comment
tcurdt Jul 24, 2016
9d8f662
added test
tcurdt Jul 24, 2016
3f948b7
renamed test, added to project
tcurdt Jul 24, 2016
ecc76a0
fixed the test
tcurdt Jul 24, 2016
82c6fd5
delegate to rex_value
tcurdt Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Source/UIKit/UIPageControl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
//
// UIPageControl.swift
// Rex
//
// Created by Torsten Curdt on 7/24/16.
// Copyright (c) 2015 Torsten Curdt. All rights reserved.
//

import ReactiveCocoa
import UIKit

extension UIPageControl {

/// Wraps a label's `numberOfPages` value in a bindable property.
public var rex_numberOfPages: MutableProperty<Int> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why label and not pageControl

return associatedProperty(self, key: &numberOfPagesKey, initial: { $0.numberOfPages }, setter: { $0.numberOfPages = $1 })
}

/// Wraps a label's `currentPage` value in a bindable property.
public var rex_currentPage: MutableProperty<Int> {
return associatedProperty(self, key: &currentPageKey, initial: { $0.currentPage }, setter: { $0.currentPage = $1 })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use UIControl's rex_value for this purpose, that way we can keep this property up-to-date since we will process each UIControlEventValueChanged event triggered from any user interaction.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not objecting I am not sure I can follow the argument. What do you mean by "keep this property up-to-date"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will keep currentPage and rex_currentPage in sync. Right now we can control UIPageControl's currentPage but if the user interacts with the page control changing to a certain page manually, triggering a UIControlEventValueChanged event, our bindable property will not be updated with the new index.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcurdt can you please change it to:

public var rex_currentPage: MutableProperty<Int> {
    return UIControl.rex_value(self, getter: { $0.currentPage }, setter: { $0.currentPage = $1 })
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

}
}

private var numberOfPagesKey: UInt8 = 0
private var currentPageKey: UInt8 = 0