Add support for Xcode 8 and Swift 2.3 #150
Conversation
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| }; | ||
| D8715DE81C21172A005F4191 /* (null) */ = { |
|
👍 |
| github "antitypical/Result" "2.1.1" | ||
| github "ReactiveCocoa/ReactiveCocoa" "v4.2.1" | ||
| github "antitypical/Result" "2.1.3" | ||
| github "ReactiveCocoa/ReactiveCocoa" "v4.2.2" |
There was a problem hiding this comment.
Explicitly requiring ~> 4.2.2 in Cartfile would be better I think.
|
|
|
[.travis.yml] |
This should stabilise testing on certain platforms: Quick/Quick@ed9c17b
Now that we're testing on two different Xcode versions, prebuilt binaries will always fail on one of them.
|
Ok, so it looks like CI passed on Xcode 8 but then failed with this: Seems like a Travis thing? And the Xcode 7.3 build just never completes, timing out when building dependencies. Perhaps there should be a separate job for each Xcode/platform combination? That would be 8 total builds, but we'd gain concurrency and more granular failures across platforms. |
|
If someone's available, could https://travis-ci.org/RACCommunity/Rex/builds/151239865 be killed? It was misconfigured and none of the builds are starting (I've since pushed a fix). |
|
I've just killed it 🔪 |
|
Ok, so the build finally finished. The failures seem to be mostly be timeouts of some kind or another. I'm not sure what the best way to proceed is, the build times here are kinda ridiculous. |
|
You may try #150 (comment) |
|
Is there a plan to fix and merge this PR? I am currently blocked because I need this Swift 2.3 support for RAC 4.2.2 Thanks!! |
The new build matrix should have 10 items: 2 Xcodes * 5 platforms (Mac, iOS, tvOS, watchOS, CocoaPods).
|
Ok, we're green! @c0diq hopefully we can get this in now. |
|
Looks good to me. 👍🏻 |
No description provided.