Fix associated object key shadowing #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UIControl.selected
Previously these were taking the address of fields on `self` which shadowed the static keys declared in the file. This could've gone unnoticed if the fields on UIControl didn't all resolve to the same address.
neilpa
added a commit
that referenced
this pull request
Nov 22, 2015
Fix associated object key shadowing
neilpa
added a commit
that referenced
this pull request
Apr 1, 2016
These were missed when the other extensions were updated to use keys instead of corresponding members which can be problematic (#65).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64