ReactiveCocoa 4.0 support #83
Conversation
|
👍 |
|
|
|
Sorry, forgot the Mac target. Should be fixed now. |
|
Thanks! |
| @@ -18,8 +18,8 @@ Pod::Spec.new do |s| | |||
| s.watchos.deployment_target = '2.0' | |||
| s.tvos.deployment_target = '9.0' | |||
|
|
|||
| s.source = { :git => 'https://github.com/neilpa/Rex.git', :tag => '0.9.0-RC.2' } | |||
| s.dependency 'ReactiveCocoa', '4.0.0-RC.2' | |||
| s.source = { :git => 'https://github.com/neilpa/Rex.git', :tag => '0.9.0' } | |||
There was a problem hiding this comment.
I'm guessing you see into the future when @neilpa makes the actual tag? But on a serious note, could you so I can push a new spec to trunk? 👯
There was a problem hiding this comment.
Heh. I started a new release right after I merged this https://github.com/neilpa/Rex/releases/tag/0.9.0
There was a problem hiding this comment.
Hmm, it's been a long time since I updated a podspec and the process has changed quite a bit. I'll try and get it pushed today though.
There was a problem hiding this comment.
🎉 I just realized the other dependencies have no updated their specs either. But thanks for being so super quick. 👏
There was a problem hiding this comment.
Looks like you can push this new spec too since you're marked as the maintainer in cocoapods.
There was a problem hiding this comment.
Yeah, but the spec fails linting due to Result not being updated. So in either case we have to wait for the spec of Result 1.0.2 to be pushed.
Fixes a minor issues with the final ReactiveCocoa 4.0 release, which uses
Result.NoErrorinstead of its ownNoErrortype. I also updated the Podspec and changed the version to 0.9.0.