Adds rex_date to UIDatePicker. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func testUpdatePropertyFromPicker() { | ||
| let expectation = self.expectationWithDescription("Expected rex_date to send an event when picker's date value is changed by a UI event") | ||
| defer { self.waitForExpectationsWithTimeout(2, handler: nil) } |
There was a problem hiding this comment.
My guess is that this blocks the test "UI thread" preventing the action event from being delivered and the expectation from being fulfilled. I'm not at all familiar with the threading of XCTest so not sure what can be done to make this work
There was a problem hiding this comment.
Also, the UITextField test does look similar but the events are delivered via NSNotificationCenter which probably does something different under the hood than target/action.
|
I disabled the test and merged this in. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rex_datemutable property toUIDatePickerthat sends a value every time the picker is updates through a UI event and also updates the picker's date property when the mutable property is updated (this does not cause an infinite loop because I am using target/action which doesn't get called when a property is changed programmatically).I know this works because I testes it on a project but one of the tests are not passing and I am doing exactly the same you are doing in the
UIButtontests. Maybe you can help me there.