Harmonize exception handling #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blootsvoets
reviewed
Aug 6, 2018
| errorParams.put("producer", sourceType.getProducer()); | ||
| errorParams.put("model", sourceType.getModel()); | ||
| errorParams.put("subject-id", subject.getUser().getLogin()); | ||
| errorParams.put("sourceId", sourceRegistrationDto.getSourceId().toString()); | ||
| throw new CustomParameterizedException("InvalidRequest", errorParams); | ||
| throw new BadRequestException("Cannot find assigned source with sourceId or a source " |
There was a problem hiding this comment.
Is this not a conflictexception? E.g. http status code 409?
There was a problem hiding this comment.
This cannot be a conflict request, since we did not get enough data to process this request. This is a situation where we cannot both create a new source, or update source.
blootsvoets
reviewed
Aug 6, 2018
| * @return {@link Subject} loaded. | ||
| */ | ||
| public Subject findOneByLogin(String login) { | ||
| Optional<Subject> subject = subjectRepository.findOneWithEagerBySubjectLogin(login); |
There was a problem hiding this comment.
Use Optional#orElseThrow() in these cases
blootsvoets
reviewed
Aug 6, 2018
| .get()); // we know the list is not empty so calling get() is safe here | ||
| throw new InvalidRequestException( | ||
| // we know the list is not empty so calling get() is safe here | ||
| "Cannot delete a source-type that " + "is being used by project(s)", SOURCE_TYPE, |
There was a problem hiding this comment.
Add back the list of projects here? The reduce(String.join).get() can be replaced with collect(Collectors.joining)
blootsvoets
previously approved these changes
Aug 6, 2018
blootsvoets
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factored error handling in MP. This PR allows to use specific exceptions with a common format and appropriate HTTP Status code and some refactoring where relevant.