Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/subject pair dialog component expansion2 #713

Merged
merged 17 commits into from
Sep 12, 2023
Merged

Feature/subject pair dialog component expansion2 #713

merged 17 commits into from
Sep 12, 2023

Conversation

Bdegraaf1234
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 commented Sep 8, 2023 •
edited
Loading

Description: Adds components to display the requested fields (name, date of birth, external id) in the subject-pair-dialogue. Continuation from #710 after rebasing onto dev branch

Fixes #706

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Sep 8, 2023
Closed
5 tasks
@Bdegraaf1234 Bdegraaf1234 changed the base branch from master to dev September 8, 2023 08:21
@Bdegraaf1234
Revert "added defaultValue to the requested fields in issue #706. Thi…
b30c3c6 
…s is likely not the most clean way to do this, at it was done by altering the changelogs, which negates their purpose to some extent."

This reverts commit b722d73.
@Bdegraaf1234
set of subjects that has varies permutations of present or absent opt…
976340f 
…ional values
@Bdegraaf1234
add date of birth and person name to set of subjects in the dev db th…
ddc4d5f 
…at has varies permutations of present or absent optional values
@Bdegraaf1234
inserted *ngIf to hide empty input components
ab0e55b
@Bdegraaf1234 Bdegraaf1234 self-assigned this Sep 11, 2023
@Bdegraaf1234 Bdegraaf1234 marked this pull request as draft September 11, 2023 08:18
@Bdegraaf1234
change the subject testing data file so that when ordering by externa…
6a50147 
…l ID, the first and last subject are sub-1 and sub 51 respectively, so that the test passes.
@Bdegraaf1234 Bdegraaf1234 marked this pull request as ready for review September 11, 2023 11:18
blootsvoets
blootsvoets previously approved these changes Sep 12, 2023
View reviewed changes
@Bdegraaf1234 Bdegraaf1234 dismissed blootsvoets’s stale review September 12, 2023 11:31

The merge-base changed after approval.

@blootsvoets blootsvoets merged commit 0b6bab2 into dev Sep 12, 2023
@blootsvoets blootsvoets deleted the feature/subject-pair-dialog-component-expansion2 branch September 12, 2023 11:31
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Sep 14, 2023
Closed
@blootsvoets blootsvoets mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets left review comments

@nivemaham nivemaham Awaiting requested review from nivemaham

Assignees

@Bdegraaf1234 Bdegraaf1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show external ID on pair dialog
2 participants
@Bdegraaf1234 @blootsvoets