741 fully move to kotlin #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
blootsvoets
reviewed
Oct 27, 2023
radar-auth/src/main/java/org/radarbase/auth/token/DataRadarToken.kt
Outdated
Show resolved
Hide resolved
radar-auth/src/test/java/org/radarbase/auth/authentication/TokenValidatorTest.kt
Outdated
Show resolved
Hide resolved
radar-auth/src/test/java/org/radarbase/auth/authentication/TokenValidatorTest.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/config/AsyncConfiguration.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/config/CacheConfiguration.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/config/DatabaseConfiguration.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/radarbase/management/config/LoggingConfiguration.kt
Outdated
Show resolved
Hide resolved
…ctually annotate the fields/parameters rather than the types (?)
…urceIntTest.kt and SourceDataResourceIntTest.kt
project: organization was not provided as valid json Sourcetype: catalogversion was incorrectly set during save subject: incomplete projectDTO was provided (no name). this could be resolved by looking up the name if an id is provided.
…e, and overwrites the field on get() to prevent inconsistencies. Only if there is no organization.name, the original field can be used.
…ase/ManagementPortal into 741-fully-move-to-kotlin
yatharthranjan
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
LGTM. I have just quickly done a pass since I have not worked extensively on MP before and most of the files are renamed so hard to review the diff. I am approving given that this is sufficiently tested, the CI is passing and we will test it further in our stage environment.
Thanks @Bdegraaf1234 for this substantial piece of work and it will definitely make it easier to maintain.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Move classes to kotline before migrating to ory to prevent having really obfuscated pull requests for significant changes in the implementation
Fixes #741
Checklist: