Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change login flow to use Ory #924

Merged
merged 29 commits into from
Sep 13, 2024
Merged

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Aug 6, 2024

Description:

  • Converts the management portal web app login to use the auth code login flow
  • Adds support for Hydra oauth tokens by adding it as a JwksTokenVerifier
  • Adds auth server (hydra) config
  • Move all security config to SecurityConfiguration class and remove OAuth2ServerConfiguration class
  • Removes unused security, config, and oauth classes

Fixes:

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@mpgxvii mpgxvii changed the base branch from dev to feature/ory-based-authorization August 8, 2024 10:16
@mpgxvii mpgxvii changed the base branch from feature/ory-based-authorization to hydra-kratos-stack August 13, 2024 18:24
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means we can delete KratosTokenVerifierLoader

Probably good to do asap, or at least put it on a tasklist somewhere.

Otherwise, LGTM :)

@Bdegraaf1234
Copy link
Collaborator

The output of gradlew check does not show, but the test does not pass. Do you know why?

@mpgxvii mpgxvii changed the base branch from hydra-kratos-stack to feature/ory-based-authorization August 14, 2024 13:24
@Bdegraaf1234 Bdegraaf1234 marked this pull request as draft August 19, 2024 14:42
@mpgxvii
Copy link
Member Author

mpgxvii commented Aug 23, 2024

The output of gradlew check does not show, but the test does not pass. Do you know why?

I've updated this now 👍

@mpgxvii mpgxvii marked this pull request as ready for review August 29, 2024 18:12
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgxvii mpgxvii merged commit cb20142 into feature/ory-based-authorization Sep 13, 2024
5 checks passed
@mpgxvii mpgxvii deleted the feat/hydra-token branch September 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants