Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl. configuration of co-routine request timeouts #116

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

pvannierop
Copy link
Contributor

Problem

When uploading large files to Kafka concurrently, each request duration exceeds the default timeout of 30 seconds. This causes the service to return 503 http code when thought upload is proceeding correctly.

Solution

This PR implements external configuration of the timeout duration for the REST endpoints. This will allow to configure longer timeout durations on systems where needed.

These superseeded the timeouts enacted by the Grizzly server and needed to be configured for concurrent uploads of large files where each request duration exceeded the default of 30 seconds.
@pvannierop pvannierop requested a review from keyvaann November 27, 2024 07:43
@pvannierop pvannierop self-assigned this Nov 27, 2024
Copy link
Contributor

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop merged commit 71e7cc7 into main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants