Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null end dates in Oura #143

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Allow null end dates in Oura #143

merged 2 commits into from
Jul 10, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Jul 10, 2024

  • Allow null end dates in Oura for continuous pull of data

yatharthranjan
yatharthranjan approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor suggestion for brevity

oura-library/src/main/kotlin/org/radarbase/oura/request/OuraRequestGenerator.kt Outdated Show resolved Hide resolved
@mpgxvii @yatharthranjan
Refactor checking of end date for brevity
5d87b76 
Co-authored-by: Yatharth Ranjan <yatharthranjan89@gmail.com>
yatharthranjan
yatharthranjan approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgxvii mpgxvii merged commit 2c3bc7e into release-0.5.3 Jul 10, 2024
2 checks passed
@mpgxvii mpgxvii deleted the feat/allow-null-end branch July 10, 2024 15:29
@mpgxvii mpgxvii restored the feat/allow-null-end branch July 12, 2024 14:26
@mpgxvii mpgxvii deleted the feat/allow-null-end branch July 12, 2024 14:26
@mpgxvii mpgxvii restored the feat/allow-null-end branch July 12, 2024 14:27
@mpgxvii mpgxvii deleted the feat/allow-null-end branch July 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @yatharthranjan