Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update radar-auth #244

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Update radar-auth #244

merged 9 commits into from
Oct 25, 2023

Conversation

blootsvoets
Copy link
Member

@blootsvoets blootsvoets commented Oct 24, 2023 •
edited
Loading

  • Use coroutines fetch
  • Use radar-auth 2.1.0
  • Use radar-commons-kotlin 1.1.1
  • Use ktor with kotlinx-serialization
  • Use buildSrc and radar-commons-gradle for building
  • Use async for serving responses. Especially relevant for instances with a lot of users in the connector.

mpgxvii
mpgxvii previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

...rizer-app-backend/src/main/java/org/radarbase/authorizer/service/OuraAuthorizationService.kt Outdated Show resolved Hide resolved
...ckend/src/main/java/org/radarbase/authorizer/service/OAuth1RestSourceAuthorizationService.kt Outdated Show resolved Hide resolved
@blootsvoets blootsvoets merged commit f77da45 into dev Oct 25, 2023
5 checks passed
This was referenced Oct 25, 2023
Merged
Closed
@Bdegraaf1234 Bdegraaf1234 deleted the update-radar-auth-2 branch February 12, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpgxvii mpgxvii mpgxvii left review comments

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234

@Hsankesara Hsankesara Awaiting requested review from Hsankesara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blootsvoets @mpgxvii