Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nifi] NiFi helm chart #302

Merged
merged 5 commits into from
Dec 10, 2024
Merged

[nifi] NiFi helm chart #302

merged 5 commits into from
Dec 10, 2024

Conversation

Hsankesara
Copy link
Member

@Hsankesara Hsankesara commented Nov 19, 2024

Description of the change

Since cetic helm-nifi is not being maintained any more, and we are planning to integrate the NiFI in the stack, it would be good to maintain NiFi helm charts. I have copied the helm chart from the cetic/helm-nifi repo. In future, I will work on updating the nifi version to NiFi 2.0.0.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Hsankesara Hsankesara changed the title [nifi] Nifi helm charts [nifi] NiFi helm charts Nov 19, 2024
@Hsankesara Hsankesara changed the title [nifi] NiFi helm charts [nifi] NiFi helm chart Nov 19, 2024
@Hsankesara Hsankesara marked this pull request as draft November 19, 2024 12:50
@yatharthranjan
Copy link
Member

Hi, Thanks for this.

The CI is failing, you need to add a line for the new chart in the Makefile, similar to other charts with update-*. See previous PRs that added new external charts for reference.

Keeping a copy of the chart is a good idea, but I would not recommend using an archived (unmaintained) chart, as the updates and maintenance can be laborious. Instead, try finding alternative charts that are maintained, so when an update is made, you can just copy the update here, reducing the overheads. This is fine for now, but let's add an issue to update it in the future.
Some alternatives:

  1. https://artifacthub.io/packages/helm/d4n/nifi
  2. There is also a Kubernetes operator, but probably keep that for later - https://konpyutaika.github.io/nifikop/docs/1_concepts/1_start_here

@Hsankesara
Copy link
Member Author

Hi @yatharthranjan,

I'll work on the CI changes. I think the issue here is I cannot find any NiFi hem chart repo that some institution maintains. aristide/nifi seems like it's been maintained by an individual. I'm not sure how consistent it's going to be for future updates. It does have nifi-2.0, so I would have a look.

@Hsankesara Hsankesara marked this pull request as ready for review December 4, 2024 08:43
@Hsankesara Hsankesara requested a review from keyvaann December 4, 2024 12:12
Makefile Outdated
update-nifi:
@echo "Updating NiFi"
@rm -rf external/$(patsubst update-%,%,$@)
@helm repo add $(patsubst update-%,%,$@) https://artifacthub.io/packages/helm/cetic/nifi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be https://cetic.github.io/helm-charts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sure, I was just confused because the repo isn't being maintained anymore.

@Hsankesara Hsankesara requested a review from keyvaann December 4, 2024 13:09
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit 5e6f98d into main Dec 10, 2024
2 checks passed
@keyvaann keyvaann deleted the nifi-helm-charts branch December 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants