-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nifi] NiFi helm chart #302
Conversation
Hi, Thanks for this. The CI is failing, you need to add a line for the new chart in the Makefile, similar to other charts with Keeping a copy of the chart is a good idea, but I would not recommend using an archived (unmaintained) chart, as the updates and maintenance can be laborious. Instead, try finding alternative charts that are maintained, so when an update is made, you can just copy the update here, reducing the overheads. This is fine for now, but let's add an issue to update it in the future.
|
Hi @yatharthranjan, I'll work on the CI changes. I think the issue here is I cannot find any NiFi hem chart repo that some institution maintains. aristide/nifi seems like it's been maintained by an individual. I'm not sure how consistent it's going to be for future updates. It does have nifi-2.0, so I would have a look. |
Makefile
Outdated
update-nifi: | ||
@echo "Updating NiFi" | ||
@rm -rf external/$(patsubst update-%,%,$@) | ||
@helm repo add $(patsubst update-%,%,$@) https://artifacthub.io/packages/helm/cetic/nifi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be https://cetic.github.io/helm-charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sure, I was just confused because the repo isn't being maintained anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
Since cetic helm-nifi is not being maintained any more, and we are planning to integrate the NiFI in the stack, it would be good to maintain NiFi helm charts. I have copied the helm chart from the cetic/helm-nifi repo. In future, I will work on updating the nifi version to NiFi 2.0.0.
Checklist
Chart.yaml
according to semver.