Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value introduced in subclass does not propagate to constructor #467

Open
lawremi opened this issue Oct 19, 2024 · 0 comments · May be fixed by #473
Open

Default value introduced in subclass does not propagate to constructor #467

lawremi opened this issue Oct 19, 2024 · 0 comments · May be fixed by #473

Comments

@lawremi
Copy link
Collaborator

lawremi commented Oct 19, 2024

This line drops the parent properties from the constructor by name; however, I think it's valid for subclasses to add/change the default for a parent property. Since we're dropping the subclass properties, the changed default does not make it to the constructor. Self args should probably be kept (and override the parent) if they have a different default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant