Revamp method calling #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all non-dispatched arguments are passed through to the method as is. ... no longer has special handling, except as it pertains to method compatibility
|
|
||
| if (is.null(fun)) { | ||
| args <- setNames(lapply(dispatch_args, function(i) quote(expr = )), dispatch_args) | ||
| args <- c(dispatch_args, "...") |
There was a problem hiding this comment.
I don't think this is documented? I'm also not entirely sure if it is right or not. I guess to opt out of this, you provide an explicit fun
R/method.R
Outdated
Comment on lines
157
to
164
| if (names(generic_formals[i]) == "...") { | ||
| # Method doesn't have to have ... even if generic does | ||
| next | ||
| } | ||
|
|
||
| if (!identical(generic_formals[i], method_formals[i])) { | ||
| stop(sprintf("`method` must be consistent with <R7_generic> %s.\n- Argument %i in generic %s\n- Argument %i in method %s", generic@name, i, arg_to_string(generic_formals[i]), i, arg_to_string(method_formals[i])), call. = FALSE) | ||
| } |
There was a problem hiding this comment.
hmm, is this right? what about generic <- function(x, ... y = 1) with method <- function(x, y = 1)? generic_formals would be length 3 and method_formals would be length 2 then right? maybe you need to do generic_formals <- generic_formals[-i] before next
There was a problem hiding this comment.
Maybe a test to ensure that a method can't add dots if the generic doesn't have them
src/dispatch.c
Outdated
| // Lookup the promise for that argument in the environment | ||
| SEXP name = Rf_install(CHAR(STRING_ELT(gen_signature_args, i))); | ||
| // Find its name and look up its value (a promise) | ||
| SEXP name = TAG(Rf_nthcdr(FORMALS(generic), i)); |
There was a problem hiding this comment.
Is there a more efficient way to loop over this FORMALS(generic) pairlist?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #129. Fixes #85. Fixes #88.