Consistently use class_ prefix for base wrappers
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update index
Conflicts: README.Rmd README.md tests/testthat/test-method-dispatch.R
DavisVaughan
approved these changes
Mar 16, 2022
| #' * `class_atomic` is a union of `class_logical`, `class_numeric`, | ||
| #' `class_complex`, and `class_raw`. | ||
| #' * `class_vector` is a union of `class_atomic`, `class_list`, and | ||
| #' `class_expression`. |
There was a problem hiding this comment.
I had a random thought that class_numeric and friends could be union_numeric to be more self documenting, but that might not be a great idea
There was a problem hiding this comment.
I think it's nice to have a common prefix here; and the prefix really means "some wrapper around a base class/type".
| #' `class_complex`, and `class_raw`. | ||
| #' * `class_vector` is a union of `class_atomic`, `class_list`, and | ||
| #' `class_expression`. | ||
| #' |
There was a problem hiding this comment.
Do you give any advice on how to name your own custom class objects anywhere?
There was a problem hiding this comment.
Nope currently. I'll add something here saying that we reserve the class_ prefix and also add a little advice in new_class()
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Conflicts: tests/testthat/_snaps/class.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
@DavisVaughan I don't think you need to worry too much about the implementation as it should've been hard for me to screw it up, but a pass over the docs would be appreciated.