-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop processing of literals with LiteralProxies
class
#18
Conversation
processing of literals.
variable with dictionary comprehension.
Implemented unit tests for the rules.
@wrobell are you done pushing commits to this PR? Let us know when it is ready for review. |
Hi, sorry, I have raised this pull request too early. I will have few more fixes. I will comment once its done. |
Implemented unit test for cls-maxc1 OWL 2 RL rule.
Implemented unit test of eq-diff1 OWL 2 R rule.
after removal of LiteralProxies class.
@wrobell we've noticed no new commit to this branch since November 7. |
Unfortunately, this still needs work. I hope to have some time to work on it today. |
of LiteralProxies class.
This is required since removal of `LiteralProxies` class.
This pull request is ready. Please review. |
This is possible, because RDFLib supports literals in subject position now (see discussion in issue #13).
As a consequence
The change improves performance of the library, for the script below, by
about 14%.
Related blocks of code, which swallow exceptions are removed.
Unit tests for the following OWL 2 RL rules are implemented
cax-dw
cls-avf
cls-maxc1
cls-maxc2
cls-maxqc1
cls-maxqc2
cls-maxqc3
cls-maxqc4
Unit tests for RDFS closure implemented
Unit tests for OWL 2 RL extras closure implemented
Testing script