Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build and wheel dist build fixes #223

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Docker build and wheel dist build fixes #223

merged 5 commits into from
Apr 21, 2024

Commits on Apr 21, 2024

  1. Use arg/env variable for venv creation instead of hardcoded location 

    Explicitly call the venv version of pip3 to install the wheel, so it is obvious the built prez module is being installed in the venv site_packages.
    @ashleysommer
    ashleysommer committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    f4db569 View commit details
    Browse the repository at this point in the history

  2. Don't copy the whole source tree into the final image, it already has… 

    … the built prez module and all dependencies installed in the venv, it just needs main.py and supporting files.
    @ashleysommer
    ashleysommer committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    70fcb45 View commit details
    Browse the repository at this point in the history

  3. never include dist files in the docker env, this also ensures no dist… 

    … files are included inside the sdist or wheel packages (poetry excludes packaging everything in gitignore).
    @ashleysommer
    ashleysommer committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e314dca View commit details
    Browse the repository at this point in the history

  4. Don't put Dockerfile inside its own Docker build context. Its not nee… 

    …ded for the container built, and this allows incremental builds to work properly.
    @ashleysommer
    ashleysommer committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e026403 View commit details
    Browse the repository at this point in the history

  5. Put prez module's pyproject.toml _inside_ the built prez module in th… 

    …e wheel package, this allows the config builder to find it when prez is installed as a system module.

Modify the config builder to search inside the prez module for pyproject.toml if there is not one in the project top directory (enables the above functionality).
Also explicitly list all the files to include in a sdist, because should be different than the wheel bdist.
    @ashleysommer
    ashleysommer committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    5128d68 View commit details
    Browse the repository at this point in the history