-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on rdflib-jsonld #94
Conversation
I don't know why Black changed so many lines in various unrelated files in the commit. Did you run with the given Black config file? Regarding isort, that has a mind of its own. It seems to reorder imports on random files all the time, and a couple of commits later it will re-order them back.. |
I did
in the virtual env for the project (same with I believe this is correct behavior, see https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#trailing-commas . Black will split a collection of arguments to separate lines if they and in a trailing comma. I remember there used to be a bug in black where, if you call it, it'd add a trailing comma to these kinds of argument lists, which would then cause it to break them onto separate lines if run again (so running black twice didn't yield the same result as running it once). This has since been fixed, but maybe you ran into that issue? On a side note, we've had good experiences using Edit: As for isort, I think it doesn't sort imports past non-import code, so me removing
caused it to also pickup the imports below that line and sort them |
Yep, looks like you're right. this is that bug. I had pinned our version of black to 20.6b0 back in June because that was the first version which contained the I'll update it to v20.8b0 to fix that bug. |
@Panaetius This PR should now be able to be rebased against current Master to make the changeset smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase or merge against current master
I've rebased on current master. |
Closes #93
Requires RDFLib/OWL-RL#46 to be merged and released first, then needs a
poetry lock
.Isort reordered some imports in
pyshacl/validate.py
, I can undo that but as it is right now it should follow the CONTRIBUTING guidelines of the project.