-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2378: Remove unicode string form in rdflib/term.py #2384
Issue 2378: Remove unicode string form in rdflib/term.py #2384
Conversation
References: * RDFLib#2378 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
I'm not sure why something went awry for only Python 3.11. After I worked through documenting #2385, I was able to get this log output:
It seems this is unrelated enough to this PR that it's not a blocking issue, but this might be a heads-up that CI is going to complain the next time someone pushes to |
fwiw I can confirm it's unrelated to this PR, aucampia is already working to resolve the issue: #2382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good to me.
Summary of changes
This PR updates some docstrings to no longer use the Python 2 unicode string pattern (
u"some string"
).This PR is scoped to the original file where I'd encountered the problem, running
python3 -m doctest rdflib/term.py
.One outstanding
doctest
issue remains, but rather than attempt to fix everything, this PR is filed now to make incremental progress, and trial the goal progression laid out in #2383.The last issue for
rdflib/term.py
, which I think someone else will need to file a PR for, is evidenced in this shell transcript:Checklist
the same change.
main
, and more tests pass in the "Goal" branch)./examples
for new features. (N/A)CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.