-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2378 goal: Get CI to pass without ALLOW_UNICODE on doctests #2383
Conversation
This patch, without rebasing, will fail CI today. References: * RDFLib#2378 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * RDFLib#2378 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Thanks for the PR @ajnelson-nist, would be good to eliminate While I do prefer smaller PRs, I would not mind if you did everything for this in one PR for this, as it should not be too difficult to review. But also happy if they go into seperate PRs. |
Oh wait, I forgot part of my motivation for carving out other PRs: I have smacked into at leas one issue that will require slightly harder work (handling an inequality operator in |
Approved and merged. Apologies for taking so long to get to it, for small PRs like #2384 you should consider asking on Gitter/Matrix. I try to process PRs in order, and sometimes I don't even look at new PRs before older ones are processed, if I knew it was so small I would have processed it sooner. |
PRs to V6 is closed until further notice. See this for more details: |
We will be open for PRs again once this is resolved: |
Unicode literals (`u'ẋẏż'`) are redundant in Python 3 as all strings support Unicode. This change eliminates the use of Unicode literals from docstrings so that the `ALLOW_UNICODE` option flag is no longer needed for doctests. See also: - RDFLib#2383 - RDFLib#2378
Unicode literals (`u'ẋẏż'`) are redundant in Python 3 as all strings support Unicode. This change eliminates the use of Unicode literals from docstrings so that the `ALLOW_UNICODE` option flag is no longer needed for doctests. See also: - RDFLib#2383 - RDFLib#2378
This PR sets the goal state for #2378: Pass CI with a Python2 testing allowance for docstring tests removed.
This PR will be failing CI for a while. My intent is to file separate PRs to
main
and keep catching this PR up until it eventually passes. I'm aware of at least one patch that will be straightforward, one not so obvious, and am unsure how much further work would be needed.Fixes #2378
Summary of changes
This PR's sole contribution is expected to be removing
ALLOW_UNICODE
frompyproject.toml
. The rest is expected to be brought in via merging other PRs that lessen the tally of CI failures in this PR.Checklist
the same change.
./examples
for new features. (N/A)CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.