-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infixowl fix #2307
Infixowl fix #2307
Conversation
tidy `# docstring` syntax and replace antiquated namespace_manager bindings with moderm graph ns bindings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjhiggins looks good with some minor comments. I'm happy to address them in your branch.
@gjhiggins just a follow up on this, I will update your branch accordingly this weekend if there are no objections. |
Sorry for the accidental close |
Sure, no problem, thank you. |
Mm. Wonder why 3.11 is failing on rdflib/test/test_graph/test_graph.py Line 347 in cbd6151
|
This is unrelated to this PR. |
I figured it out: Looking at a way to fix it now. |
Fix the following issues in `rdflib.extras.infixowl`: - getting and setting of max cardinality only considered identifiers and not other RDF terms. - The return value of `manchesterSyntax` was wrong for some cases. - The way that `BooleanClass` was generating its string representation (i.e. `BooleanClass.__repr__`) was wrong for some cases. Other changes: - Added an example for using infixowl to create an ontology. - Updated infixowl tests. - Updated infixowl documentation. This code is based on code from: - <#2307> Changes are primarily authored by <https://github.com/gjhiggins>. --------- Co-authored-by: Graham Higgins <gjh@bel-epa.com>
@gjhiggins this now only contains changes for the node closure function additions as the rest was merged in #2390 |
Noted, thanks. Bizarrely, GH still reporting that the branch in my clone repos is 22 commits ahead, sigh. |
If you do a rebase, that should possibly improve. A squash using |
Thanks for the advice but sadly, I'm lost in my ignorance of git at this point, will have to find time to spend on understanding how rebase and squash work. |
Something profoundly amiss, can't recover a sane branch, I'm closing this PR, will delete the problematic branch and will raise another PR once I've created some tests. |
Summary of changes
IIndividual
Individual.serialize
toIndividual.snc
(subject node closure)Individual.bnc
(blank node closure)@
throughout as infix operator# docstring
syntaxChecklist
./examples
for new features.CHANGELOG.md
).so maintainers can fix minor issues and keep your PR up to date.