feat: introduce PostSendGuard for extended QP with basic support for polling extended CQ #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonJACson
changed the title
dragonJACson
commented
Sep 2, 2024
dragonJACson
force-pushed
the
dev/post-send
branch
5 times, most recently
from
d103153 to
575375d
Compare
dragonJACson
changed the title
dragonJACson
force-pushed
the
dev/post-send
branch
10 times, most recently
from
06fdc57 to
b2e807a
Compare
dragonJACson
force-pushed
the
dev/post-send
branch
3 times, most recently
from
e80e217 to
d28007e
Compare
dragonJACson
changed the title
dragonJACson
force-pushed
the
dev/post-send
branch
7 times, most recently
from
f9dfeb7 to
854c419
Compare
dragonJACson
force-pushed
the
dev/post-send
branch
from
854c419 to
c5dfc9e
Compare
dragonJACson
changed the title
dragonJACson
force-pushed
the
dev/post-send
branch
from
612b94f to
74ae1ed
Compare
dragonJACson
changed the title
FujiZ
reviewed
Sep 21, 2024
dragonJACson
force-pushed
the
dev/post-send
branch
from
74ae1ed to
3ad0e8d
Compare
FujiZ
reviewed
Sep 22, 2024
dragonJACson
force-pushed
the
dev/post-send
branch
from
3ad0e8d to
8b87826
Compare
FujiZ
approved these changes
Sep 22, 2024
dragonJACson
force-pushed
the
dev/post-send
branch
from
8b87826 to
151483c
Compare
FujiZ
approved these changes
Sep 22, 2024
We introduce a unified interface for post send operations on qp and qp_ex, with the flavor of `ibv_wr_*` APIs. We use lifetime annotations to make sure we are holding one live work request at most at the same time for one qp. Signed-off-by: Luke Yue <lukedyue@gmail.com>
We implement an iterator version of poll_cq for cq_ex, this adheres to the flavor of `ibv_start_poll` and `ibv_next_poll` APIs. Signed-off-by: Luke Yue <lukedyue@gmail.com>
We introduce trybuild as dev-dependency, and add some misused code which should fail to compile, so that we can check the lifetime annotation of PostSendGuard is working as expected. Signed-off-by: Luke Yue <lukedyue@gmail.com>
dragonJACson
force-pushed
the
dev/post-send
branch
from
151483c to
93079b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #25
Introduce
PostSendGuardas an abstraction foribv_post_sendandibv_wr_*APIs, with initial implementation for write with inline data.In
ibv_wr_set_inline_data, the user buffer would be copied immediately. Meanwhile, inibv_post_send, when user pass the inline data inwr_list, the data won't be copied until user callibv_post_send, this introduce a problem in our Rust implementation, which allows user drop the buffer betweenset_inline_dataanddo_post, that is an undefined behavior. We need lifetime annotations or copy the buffer manually, the solution is left to be discussed and implemented.