Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update On Elapsed on listpage #115

Merged
merged 86 commits into from
Dec 28, 2022
Merged

Fix Update On Elapsed on listpage #115

merged 86 commits into from
Dec 28, 2022

Conversation

RDjarbeng
Copy link
Owner

When countdown elapses the text updates but the text and icon remains green, added a refresh of the list when it elapses instead

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for rcountdown ready!

Name Link
🔨 Latest commit 5b7c82a
🔍 Latest deploy log https://app.netlify.com/sites/rcountdown/deploys/63ac6ef2a5d531000885fd2a
😎 Deploy Preview https://deploy-preview-115--rcountdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@RDjarbeng RDjarbeng changed the base branch from master to vitePWA December 22, 2022 15:54
@RDjarbeng
Copy link
Owner Author

Also removed unncessary await from displayCountdowns and changed syntax .then() to use normal try and catch

Copy link
Collaborator

@nyakotey nyakotey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this PR just made me discover bugs that are currently in master, which seems to be worse in this PR.
Please check the live updating of countdowns

@RDjarbeng
Copy link
Owner Author

Added some changes to fix issues, after small refactor 🙂

@RDjarbeng RDjarbeng added the bug fix An issue or bug fix label Dec 28, 2022
@RDjarbeng
Copy link
Owner Author

Solved quite a number of bugs with this PR

@RDjarbeng RDjarbeng merged commit a98c64a into vitePWA Dec 28, 2022
@RDjarbeng RDjarbeng mentioned this pull request Dec 29, 2022
@RDjarbeng RDjarbeng deleted the fixUpdateOnElapse branch December 29, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix An issue or bug fix
Projects
Development

Successfully merging this pull request may close these issues.

2 participants