-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Update On Elapsed on listpage #115
Conversation
✅ Deploy Preview for rcountdown ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Also removed unncessary await from displayCountdowns and changed syntax .then() to use normal try and catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this PR
just made me discover bugs that are currently in master, which seems to be worse in this PR.
Please check the live updating of countdowns
Added some changes to fix issues, after small refactor 🙂 |
…IsoStringFromDateInput
Solved quite a number of bugs with this PR |
When countdown elapses the text updates but the text and icon remains green, added a refresh of the list when it elapses instead