Create a countdown to 1st day of the year #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for rcountdown ready! 🔨 Explore the source changes: ddf9329 🔍 Inspect the deploy log: https://app.netlify.com/sites/rcountdown/deploys/61cf6f043811e50007be3337 😎 Browse the preview: https://deploy-preview-27--rcountdown.netlify.app |
nyakotey
reviewed
Dec 30, 2021
There was a problem hiding this comment.
not bad, not bad at all :)
- lots of commented section in
clock.js. If you don't mind taking some out - the
startTime()in theclock.jsseems not be in use. if you can revisit that and take that out - if its possible, move the other time related functions in
app.jsthat aren't coupled with any DOM element intoclock.js - this
day${d>1? 's':''}inapp.jswill not be needed, that will be done with html & css
styles to come later
edits across files
Preview link got leaked, prompting this quick edit
RDjarbeng
changed the title
added 2 commits
December 31, 2021 13:29
Add function for counting days (accounting for leap year)
|
Made changes to the code in terms of readability |
1 similar comment
|
Made changes to the code in terms of readability |
nyakotey
reviewed
Dec 31, 2021
| <div class="banner">CountDown to New Year <i class="fas fa-snowman"></i></div> | ||
|
|
||
| <div class="banner"> | ||
| <div class=""> Day <span class="day" id ='countDay'>X</span> / 365</div> |
|
You can improve the day count design if you want to 🙂
…On Fri, 31 Dec 2021, 14:32 Nathaniel, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.html
<#27 (comment)>:
> </div>
<div class="banner-row">
- <!-- <div class="banner"> day <span class="day">X</span> / 365</div> -->
- <div class="banner">CountDown to New Year <i class="fas fa-snowman"></i></div>
+
+ <div class="banner">
+ <div class=""> Day <span class="day" id ='countDay'>X</span> / 365</div>
:(
—
Reply to this email directly, view it on GitHub
<#27 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANY6G43FXDWFPUYIPXHNYXDUTW5HLANCNFSM5LADKF4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
edit styles
added 3 commits
December 31, 2021 20:57
update site description
|
Fixed #30 |
This was referenced Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a countdown to 1st January or New year