style whatsapp share into a button #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also testing different pc experience
testing pc and mobile sharing differences
|
✔️ Deploy Preview for rcountdown ready! 🔨 Explore the source changes: 7df1ba0 🔍 Inspect the deploy log: https://app.netlify.com/sites/rcountdown/deploys/62221b7fcec7510007fe5ec1 😎 Browse the preview: https://deploy-preview-47--rcountdown.netlify.app |
|
Well the icon is supposed to be hidden on larger screens. You can use media
query min-width(500px) to hide it. I think this solves the desktop issue.
I also wanted text that shows share to WhatsApp for a few seconds before
minimizing unto the whatsapp icon, I think that will help first time users
👥.
…On Fri, 4 Mar 2022, 12:03 netlify[bot], ***@***.***> wrote:
✔️ Deploy Preview for *rcountdown* ready!
🔨 Explore the source changes: 7130a30
<7130a30>
🔍 Inspect the deploy log:
https://app.netlify.com/sites/rcountdown/deploys/6221ffec94f2db0008311c39
😎 Browse the preview: https://deploy-preview-47--rcountdown.netlify.app
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANY6G45KXUKJCXC757RR3G3U6H3X7ANCNFSM5P5LLMXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fix header logo-name overflowing when small mobile device is in landscape
Icons are very intuitive, so having to explain yourself again is not needed. Anyways I'll use set the title attribute so it serves this purpose. Everyone happy :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RDjarbeng, you have to take a look at the changes I made in the
exportToWhatsapp()You might want to suggest edits before merging this PR.The issue with it is that only chromium browsers support the very easy to use
navigator.uadata. my workaround for other browsers is not working so well (theelse ifblock). The else part is for desktop.what to do?