-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic health, first iteration #1239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilnat
changed the title
[WIP] Basic health, first iteration
Basic health, first iteration
Aug 31, 2023
avoid dropping organs in body part containers on detached
joaoburatto
requested changes
Sep 2, 2023
got some issues ... when head is cut, a head item spawn and there's a mind swap on the new entity which works okay. However this "new" entity (the head), doesn't register in the entity system and is not found by it. I wanted to simply add it to the _spawnedPlayers synclist but it triggers a bunch of other stuff in the game mode system and such and I'm unsure if it's any wanted behavior ... fixed by setting properly the synclist in entitySystem
This reverts commit e9633df.
joaoburatto
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR has for objective implementation of the first iteration of the health system, following this roadmap :
#1192
Most is said in the road map.
To test it :
Pictures/Videos (optional)
2023-08-31.12-49-28.mp4
Changes to Files
Technical Notes (optional)
Bodyparts are networked objects, but the body layers they are made of are not, so their value are server only for now (and
it might be better to leave it that way).
They can of course be queried for specific purpose, such is done to update player speed depending on body layers damages on
foot.
Known issues
Fixes (optional)
TODO