Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the nuke #1295

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix the nuke #1295

merged 1 commit into from
Oct 31, 2023

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Oct 29, 2023

Summary

Nuke was broken because of two things :

  • missing mesh colliders on the nuke itself.
  • Issue with getting the component entity using GetComponentInTree. Contrary to GetComponentInParent, getComponentInTree uses the interaction source tree. That was not working anymore because hand scripts are no longer on the same game object as entity script on human, to keep it simple.

Related issues/PRs

Closes #1294

@cosmiccoincidence cosmiccoincidence merged commit 374c934 into RE-SS3D:develop Oct 31, 2023
2 checks passed
@stilnat stilnat deleted the fix-detonate-nuke branch November 10, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmiccoincidence cosmiccoincidence cosmiccoincidence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objective doesn't work
2 participants
@stilnat @cosmiccoincidence