Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow walls to be placed over wall mounts #1311

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Don't allow walls to be placed over wall mounts #1311

merged 2 commits into from
Nov 11, 2023

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Nov 11, 2023 •
edited
Loading

Summary

All in the title

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

Testing

Place a wall mount on a wall and try to build a wall on it.

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Related issues/PRs

closes #1044

@cosmiccoincidence cosmiccoincidence added the Tilemaps Tasks related to the tilemap system or its connectors. label Nov 11, 2023
cosmiccoincidence
cosmiccoincidence approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

@cosmiccoincidence cosmiccoincidence merged commit c27ea7b into RE-SS3D:develop Nov 11, 2023
2 checks passed
@stilnat stilnat deleted the fix-wall-mount-in-walls branch November 16, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmiccoincidence cosmiccoincidence cosmiccoincidence approved these changes

Assignees
No one assigned
Labels
Tilemaps Tasks related to the tilemap system or its connectors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can Build a Wall covering Wall-Mounts
2 participants
@stilnat @cosmiccoincidence