Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable all unnecessary components on construction hologram #1367

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Dec 1, 2023

Summary

Very small PR, to solve an issue that bugs me for my electricity PR. Construction hologram should not do anything beside displaying visually the item to pose. Currently, all the monobehaviours on the hologram will start and try to execute some logic. I ru into some trouble because of that. What this PR does is that it disable all monobehaviours upon instantiating an object to be an hologram. I've tried with around 30 holograms and didn't notice any issue.

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

Testing

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

Related issues/PRs

@iamteapot422 iamteapot422 merged commit 1996aa3 into RE-SS3D:develop Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants