Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large wall mount clipping (#1347) #1433

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

withwater
Copy link
Contributor

Summary

Add isLarge boolean to TileObjectSo.cs and use that boolean value to check if there are existing large wall mounts in BuildChecker.cs. If there is, disallow building

Screenshot 2024-03-03 185009

Closes #1347

Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good do me, my only requirement would be that this isLarge bool be changed on the wallmounts that should have it as true, and also that you update your branch. Currently 2 commits behind develop

@cosmiccoincidence cosmiccoincidence added the Fix A fix for a bug. label Mar 13, 2024
Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work dude welcome to the contributor club !

@stilnat stilnat merged commit 1fdb32a into RE-SS3D:develop Mar 15, 2024
2 checks passed
@withwater
Copy link
Contributor Author

Thanks a lot nath! Looking forward to contributing more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix A fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallmounts can clip into each other
3 participants