Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inventory slots rearrange upon creating a new round #1434

Merged

Conversation

David-Goru
Copy link
Contributor

The Slots list in InventoryView.cs was keeping a list of destroyed slots between rounds, breaking the order of slots after the first round

Summary

It's a really small fix, I'm just clearing the Slots list after destroying the slots

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Testing

Start a round, stop the round, and start another round during the same play session. Slots should be consistent now

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

Related issues/PRs

Closes #1361

The Slots list was keeping a list of destroyed slots between rounds, breaking the order of slots after the first round
@stilnat
Copy link
Contributor

stilnat commented Mar 10, 2024

simple and works well, good job !

Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple and works well, good job !

@stilnat stilnat merged commit 6222a50 into RE-SS3D:develop Mar 10, 2024
2 checks passed
@David-Goru David-Goru deleted the bugfix/slots-rearrange-on-new-round branch March 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory slots rearrange upon creating a new round
2 participants