Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add open close interactions with lockers #1459

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Feature] Add open close interactions with lockers #1459

merged 1 commit into from
Oct 30, 2024

Conversation

joaoburatto
Copy link
Contributor

@joaoburatto joaoburatto commented Oct 20, 2024 •
edited
Loading

Summary

Adds lockering to lockers. Pretty simple change

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Testing

  • The locker door is synced between clients
  • The locker door is synced on late join

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

  • Removed the Scenes asset database, as it was causing issues due to scenes not being able to be addressable and in the build settings at the same time

Related issues/PRs

stilnat
stilnat requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I'm just wondering about the scene issue, we can speak of it more on discord.

stilnat
stilnat approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@stilnat stilnat merged commit 62c9a9e into RE-SS3D:develop Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stilnat stilnat stilnat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoburatto @stilnat