-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old builds not being deleted #211
Comments
Sorry, been a bit busy lately having started a new job so things have kind of falling by the wayside. I shall investigate tomorrow evening Can you go into Admin > Projects and edit the project and see what you have the "Builds to keep" setting set to? |
Hi, I have checked all repos and some have as many as 85 builds |
Awesome! Are there any logs in the "Purge Old Releases" step in any of the recent deployments? Can you try running $ (ls -t|head -n 10;ls)|sort|uniq -u) in the "builds" directory for one of the projects and paste the output? Also, can you check if the |
i don't see logs for any of deployment. that command shows me error
|
Sorry, extra bracket at the end, should be $ (ls -t|head -n 10;ls)|sort|uniq -u |
please check, 20160401191636 |
As a side, I've noticed on our deploys that if our software creates files with a different permission (our offending tool was our less compiler) then deployer might fail to remove the files, and thus leave some release folders. |
hmm.... then how to solve that problem? |
Hmm, very interesting that you have no log output Have the deployments been marked as "Completed with errors". Failure to delete builds won't cause a "Failed" deployment as it would have been activated by that stage, however in that case I would expect there to be some message in the log saying what the problem is |
Can you try $ (ls -t|head -n 11;ls)|sort|uniq -u||xargs rm -rf That SHOULD delete the builds, it is what deployer runs. Interested to see if you get any output when doing it manually. Notice that the number has increased from 10 to 11, that is what deployer does so that it keeps the new build and the 10 previous builds |
thats the output but builds are not deleted and yes, i mean in deployment page only but i don't see any log against "Purge old releases" |
Crap I've done it again, sorry typo in the previous command, should be $ (ls -t|head -n 11;ls)|sort|uniq -u|xargs rm -rf |
that seems to delete all builds except last 10 |
Hmm, so it works when running manually, that is odd :| |
hmm, |
No, connects to the targer server via SSH and runs commands |
Do you have a log in storage/logs/ ? It should contain the commands run on a deployment. Could you maybe supply a copy of your DB? $ php artisan db:backup --database=mysql --destination=backup.sql --compression=null --destination=$HOME Will backup your DB to |
I just sent you logs, db over mail, |
Got them thanks, will try and take a look at that this evening, otherwise tomorrow |
Hey, both the zip files are the DB dump |
Hey sorry.... |
@dancryer has confirmed he has the problem also, still trying to recreate it. Really weird |
Found the problem, will fix it when I get home from work and release a new version Needless to say, I'm an idiot |
Hey.... you are a great guy producing something great... don't feel bad for one single bug... I really appreciate your work..... you may know or not....i visit this page repo so often that its one of 8 thumbnails in my chrome ;) and you are saving literally many hours of many devs for manually logging in and git pulling. |
* master: Updated CHANGELOG Fixes #211 Correctly changes to the releases directory before trying to delete folders Updated dependencies Add cd to profile Update dependencies Tweak readme formatting Syntax tweak Remove bash prompt as this is now managed by my sshrc Removed vagrant cachier Explicitly enable caches Add vagrant cachier Comments Add a few more bash options Fixed .env template Fixes #209 Added trusted proxies package Tweak vagrantfile to use gitconfig from my dotfiles
Before submitting your issue, please make sure that you've checked all of the checkboxes below.
php -v
composer install --no-dev
from the root of your installation.npm install --production
from the root of your installation.rm -rf bootstrap/cache/*
from the root of your installation.To help us better understand your issue, please answer the following.
Expected behaviour
Previous builds should be removed from server
Actual behaviour
it keep on adding new builds so server running out of space.
when checked, it has 44 builds totally and taking up 6.1GB space 😢
Steps to reproduce
If your issue requires any specific steps to reproduce, please outline them here.
Environment info
Operating System:
PHP Version:
Node Version:
Database System:
Database Version:
Logs (see storage/logs/) or other output that would be helpful
(If logs are large, please upload as attachment).
The text was updated successfully, but these errors were encountered: