Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments failing when repository mirror needs updating #323

Closed
6 tasks done
lorvent opened this issue Feb 25, 2017 · 10 comments
Closed
6 tasks done

Deployments failing when repository mirror needs updating #323

lorvent opened this issue Feb 25, 2017 · 10 comments

Comments

@lorvent
Copy link

lorvent commented Feb 25, 2017

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

  • You're running the latest release version of Deployer.
  • Ensure that you're running at least PHP 5.6.4, you can check this by running php -v
  • You've ran composer install --no-dev from the root of your installation.
  • You've ran npm install --production from the root of your installation.
  • You've ran rm -rf bootstrap/cache/* from the root of your installation.
  • You have restarted the queue listener and node socket server.

To help us better understand your issue, please answer the following.

Expected behaviour

Whenever a commit is made, it triggers webhook and deployment should be made

Actual behaviour

Deployments failing with status "cancelled"

Steps to reproduce

I am using self hosted gitlab,
pushing to repo.

Environment info

Operating System:
PHP Version:
Node Version:
Database System:
Database Version:

Logs (see storage/logs/) or other output that would be helpful

(If logs are large, please upload as attachment).

@REBELinBLUE
Copy link
Owner

Investigating now, I suspect this is related to #301

@lorvent
Copy link
Author

lorvent commented Feb 25, 2017

I don't think its just related to that.

yesterday i updated to latest version and after that we deployed code for more than 30 times and everytime it failed.

but when ever i make deployment manually, it works properly.

so i am suspecting its related to something else

PS: i did config:clear etc ... does that have any effect?

@REBELinBLUE
Copy link
Owner

Found the problem, fixing it now

REBELinBLUE added a commit that referenced this issue Feb 25, 2017
…t should not be queued but done in sequence
@REBELinBLUE
Copy link
Owner

Can you change out branch bug/323 and see if that works?

@REBELinBLUE REBELinBLUE changed the title webhook deployments failing Deployments failing Feb 25, 2017
@REBELinBLUE REBELinBLUE changed the title Deployments failing Deployments failing when repository mirror needs updating Feb 25, 2017
@lorvent
Copy link
Author

lorvent commented Feb 25, 2017

I just tried that branch,
still its same 😢


only webhooks failing

manual deployments working 100% fine

@REBELinBLUE
Copy link
Owner

REBELinBLUE commented Feb 25, 2017

Did you run app:update after pulling? (or queue:restart)

Need to restart the queue listener

@lorvent
Copy link
Author

lorvent commented Feb 25, 2017

my bad...

after app:update its working 100% fine.

You are awesome! ✨ 💥

@REBELinBLUE
Copy link
Owner

Awesome! I'll get it merged in and released this evening

@lorvent
Copy link
Author

lorvent commented Feb 25, 2017

BTW, I see that you added many test cases....and i find it very interesting.

did you learn any book on it or any other sources you can recommend for writing test cases in laravel?

@REBELinBLUE
Copy link
Owner

Not really to be honest, just learnt through doing I'm afraid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants