Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer gets into an infinite loop if there are PDO drivers loaded before MySQL #254

Merged
merged 2 commits into from
Aug 2, 2016

Conversation

moxx
Copy link
Contributor

@moxx moxx commented Jul 22, 2016

intersect will preserve the original collection's keys.
[ 1 =>'mysql', 2 => 'pgsql'] will fail with default index 0.

intersect will preserve the original collection's keys.
[ 1 =>'mysql', 2 => 'pgsql'] will fail with default index 0.
@REBELinBLUE
Copy link
Owner

Thanks. Took me a while to figure out what is happening.

Basically if you have a PDO extension installed which comes before "mysql" alphabetically, for example "firebird" it will have the index of 0 but because that isn't one of the supported drivers it causes problems.

@REBELinBLUE REBELinBLUE changed the title rearrange keys for DatabaseDrivers Installer gets into an infinite loop if there are PDO drivers loaded before MySQL Aug 2, 2016
@REBELinBLUE REBELinBLUE merged commit c053535 into REBELinBLUE:master Aug 2, 2016
REBELinBLUE added a commit that referenced this pull request Aug 2, 2016
* master:
  Updated ioredis
  Updated google2fa library
  Fixes #254
  Fixes #256 - Git tag names causing a fatal error if they are not valid version string
  Fixed gulpfile so that assets don't get removed before they are versioned
  Updated dependencies

Conflicts:
	composer.json
	composer.lock
	gulpfile.js
	socket.js
REBELinBLUE added a commit that referenced this pull request Aug 6, 2016
* master: (60 commits)
  Updated CHANGELOG
  Fixes #257 - Touch files when extracting to prevent warnings about timestamps
  Update README.md
  Added a note about a common error
  Updated ioredis
  Updated google2fa library
  Fixes #254
  Fixes #256 - Git tag names causing a fatal error if they are not valid version string
  Fixed gulpfile so that assets don't get removed before they are versioned
  Updated dependencies
  Updated dependencies
  Priority WS for optimal transport browser (#250)
  Ignore suggestions when installing Composer deps (#252)
  Fix style issue
  Revert "[Snyk Alert] Fix for 2 vulnerable dependency paths" (#245)
  fix: package.json & .snyk to reduce vulnerabilities (#244)
  Handling the timeout checking for an update on github, i.e. when I am at work behind a proxy
  Added a check to the updatre script to ensure npm install has been run
  Update dialog.blade.php (#239)
  Silence PHPMD
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants