-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper sample IDs inside feature tables #153
Conversation
@xtrojak, I've checked out to this branch and fetched the new test data but the following tests fail: ...
Can't combine `..1$sample_id` <double> and `..2$sample_id` <character>.
or
...
Can't combine `..1$sample_id` <character> and `..2$sample_id` <integer>. Do you have any idea what I might be missing? I've run the tests in the devcontainer. |
The same tests fail with [ FAIL 14 | WARN 21 | SKIP 4 | PASS 24 ]
Error: Test failures
In addition: Warning messages:
1: In features$cluster : closing unused connection 6 (<-localhost:11634)
2: In features$cluster : closing unused connection 5 (<-localhost:11634)
Execution halted
1 error ✖ | 6 warnings ✖ | 7 notes ✖
Error: R CMD check found ERRORs
Execution halted |
@maximskorik Are you sure you fetched the new test data properly? If you just run the I suppose we should add |
Thanks for the advice! That must've been my problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass and the new test-data looks good. Thanks, @xtrojak!
This can be merged. Also if you could update the call to wget
with -O
in README.md that would be nice.
All feature tables contained arbitrary (resp. based on input order) integer sample IDs. The original name of the sample was lost during the feature extraction process. This PR reintroduces them again and uses them to identify the sample across the computation.
Requires files update here.